Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace certificate chain info query usage with certificate download #2081

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Replace certificate chain info query usage with certificate download #2081

merged 1 commit into from
Jun 18, 2024

Conversation

ndr-ds
Copy link
Contributor

@ndr-ds ndr-ds commented May 30, 2024

Motivation

Now that we can download certificates, using the chain info query isn't needed anymore

Proposal

Use the download certificate entrypoint instead

Test Plan

CI

This was referenced May 30, 2024
Merged
Closed
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented May 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andresilva91 and the rest of your teammates on Graphite Graphite

@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch 4 times, most recently from ab42c36 to e145d6d Compare May 30, 2024 15:57
@ndr-ds ndr-ds marked this pull request as ready for review May 30, 2024 17:16
@graphite-app graphite-app bot requested review from afck, MathieuDutSik, jvff, ma2bd, Twey and christos-h and removed request for afck May 30, 2024 17:16
@graphite-app Graphite App
Copy link

graphite-app bot commented May 30, 2024

Graphite Automations

"Assign reviewers" took an action on this PR • (05/30/24)

6 reviewers were added to this PR based on Andre da Silva's automation.

@ndr-ds ndr-ds mentioned this pull request May 30, 2024
Merged
@ndr-ds ndr-ds force-pushed the 05-29-replace_blob_chain_info_query_usage_with_blob_download branch 2 times, most recently from 4551e25 to df695bc Compare May 30, 2024 21:07
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from e145d6d to 9d817ad Compare May 30, 2024 21:14
@ndr-ds ndr-ds force-pushed the 05-29-replace_blob_chain_info_query_usage_with_blob_download branch from df695bc to adb92b5 Compare May 31, 2024 02:29
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from 9d817ad to a803404 Compare May 31, 2024 02:29
@ndr-ds ndr-ds force-pushed the 05-29-replace_blob_chain_info_query_usage_with_blob_download branch from adb92b5 to d00c5ae Compare May 31, 2024 02:36
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from a803404 to 056ad62 Compare May 31, 2024 02:36
@ndr-ds ndr-ds force-pushed the 05-29-replace_blob_chain_info_query_usage_with_blob_download branch from d00c5ae to 5166833 Compare May 31, 2024 02:56
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from 056ad62 to fca41fc Compare May 31, 2024 02:56
@ndr-ds ndr-ds mentioned this pull request May 31, 2024
Closed
@ndr-ds ndr-ds force-pushed the 05-29-replace_blob_chain_info_query_usage_with_blob_download branch from 5166833 to 10dbe38 Compare May 31, 2024 15:30
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from fca41fc to 6924a6f Compare May 31, 2024 15:30
@ndr-ds ndr-ds mentioned this pull request May 31, 2024
Closed
This was referenced May 31, 2024
Merged
Merged
@ndr-ds ndr-ds force-pushed the 05-29-replace_blob_chain_info_query_usage_with_blob_download branch from 10dbe38 to 4e2ecb0 Compare June 1, 2024 03:23
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from 6924a6f to 22df812 Compare June 1, 2024 03:23
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from 22df812 to 583b56e Compare June 17, 2024 07:11
@ndr-ds ndr-ds changed the base branch from 05-29-replace_blob_chain_info_query_usage_with_blob_download to 05-28-grpc_entrypoint_to_download_a_certificate June 17, 2024 07:11
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from 583b56e to d60e1f5 Compare June 17, 2024 07:28
@ndr-ds ndr-ds force-pushed the 05-28-grpc_entrypoint_to_download_a_certificate branch from c1b9285 to bb19397 Compare June 17, 2024 12:18
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from d60e1f5 to c69c426 Compare June 17, 2024 12:18
@ndr-ds ndr-ds force-pushed the 05-28-grpc_entrypoint_to_download_a_certificate branch from bb19397 to ca5a8ab Compare June 17, 2024 16:06
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from c69c426 to 46e0874 Compare June 17, 2024 16:09
@ndr-ds ndr-ds force-pushed the 05-28-grpc_entrypoint_to_download_a_certificate branch from ca5a8ab to 25c740e Compare June 17, 2024 22:15
Base automatically changed from 05-28-grpc_entrypoint_to_download_a_certificate to main June 18, 2024 07:44
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from 46e0874 to 943c64d Compare June 18, 2024 08:03
afck
afck reviewed Jun 18, 2024
View reviewed changes
linera-core/src/client.rs Outdated Show resolved Hide resolved
afck
afck reviewed Jun 18, 2024
View reviewed changes
linera-core/src/local_node.rs Outdated Show resolved Hide resolved
afck
afck reviewed Jun 18, 2024
View reviewed changes
linera-core/src/local_node.rs Outdated Show resolved Hide resolved
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch 2 times, most recently from 20f4628 to 6c79a85 Compare June 18, 2024 09:55
afck
afck reviewed Jun 18, 2024
View reviewed changes
linera-core/src/local_node.rs Outdated Show resolved Hide resolved
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from 6c79a85 to 340b0a1 Compare June 18, 2024 11:13
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented Jun 18, 2024 •
edited
Loading

Merge activity

  • Jun 18, 8:14 AM EDT: @andresilva91 started a stack merge that includes this pull request via Graphite.
  • Jun 18, 8:15 AM EDT: @andresilva91 merged this pull request with Graphite.

@ndr-ds ndr-ds merged commit d914903 into main Jun 18, 2024
4 checks passed
@ndr-ds ndr-ds deleted the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch June 18, 2024 12:15
@ndr-ds ndr-ds linked an issue Jun 18, 2024 that may be closed by this pull request
Simplify chain info queries and always use separate GRPC queries to download blobs and certificates #2072
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathieuDutSik MathieuDutSik MathieuDutSik left review comments

@afck afck afck approved these changes

@jvff jvff Awaiting requested review from jvff

@ma2bd ma2bd Awaiting requested review from ma2bd

@Twey Twey Awaiting requested review from Twey

@christos-h christos-h Awaiting requested review from christos-h

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify chain info queries and always use separate GRPC queries to download blobs and certificates
3 participants
@ndr-ds @MathieuDutSik @afck